Recently Written · git

sacc

Mirror of git://bitreich.org/sacc, the sacc gopher client from bitreich.org.

git clone https://github.com/equwal/sacc

Log | Files | Refs


commit f1432f5a5c56bad44485d9dee8fe92e6d09e1f4c
Hiltjo Posthuma <hiltjo@codemadness.org>
2020-07-02 23:26:09 +0200

popen: remove close-on-exec flag to increase portability a bit

POSIX says:
"If mode is any other value, the result is unspecified.".

On atleast older glibc versions (afaik 2008 and older) and on current HaikuOS
it seems to not execute popen when "e" is set and set errno to EINVAL.

 sacc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sacc.c b/sacc.c
index a58410a..3f5eb70 100644
--- a/sacc.c
+++ b/sacc.c
@@ -285,7 +285,7 @@ displaytextitem(Item *item)
 		return;
 	case 0:
 		parent = 0;
-		if (!(pagerin = popen("$PAGER", "we")))
+		if (!(pagerin = popen("$PAGER", "w")))
 			_exit(1);
 		fputs(item->raw, pagerin);
 		exit(pclose(pagerin));